Conversation
a460dce to
3ff3515
Compare
1.25.0-rc.33ff3515 to
9a6303e
Compare
This version includes bazel-contrib/rules_go#4397 which addresses the build fialure we were seeing.
9a6303e to
5e2a560
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Go version from 1.24.0 to 1.25.0 across the codebase to modernize the toolchain and support newer Go features and improvements.
- Updates Go module requirements and toolchain version
- Adjusts build environment compatibility settings
- Updates test action default Go version and Bazel rules
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/extractor/go.mod | Updates Go version requirement and toolchain from 1.24 to 1.25 |
| go/extractor/autobuilder/build-environment.go | Updates maximum supported Go version to 1.25 |
| go/actions/test/action.yml | Updates default Go test version to 1.25.0 |
| MODULE.bazel | Updates Bazel rules_go version and Go SDK download version |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
mbg
approved these changes
Aug 13, 2025
Member
mbg
left a comment
There was a problem hiding this comment.
Looks good!
I see that rules_go now works out-of-the-box and the workaround is no longer needed, which is great too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure of Go Resolve Build Environment Tests looks expected. The test does pass on the internal PR (after workflow updates).
See the internal PR for a DCA experiment.